Clean up search code, limit bookmarks list by query and/or tags

.vscode/settings.json

@@ -2,6 +2,7 @@
     "cSpell.words": [
         "bolthold",
         "colly",
+        "htmx",
         "incpatch",
         "linkwallet",
         "nicetime",

db/bookmarks.go

@@ -18,6 +18,11 @@ type BookmarkManager struct {
 	scrapeQueue chan *entity.Bookmark
 }
 
+type SearchOptions struct {
+	Query string
+	Tags  []string
+}
+
 func NewBookmarkManager(db *DB) *BookmarkManager {
 	return &BookmarkManager{db: db, scrapeQueue: make(chan *entity.Bookmark)}
 }
@@ -94,28 +99,12 @@ func (m *BookmarkManager) LoadBookmarkByID(id uint64) entity.Bookmark {
 	return ret
 }
 
-func (m *BookmarkManager) LoadBookmarksByIDs(ids []uint64) []entity.Bookmark {
-	// log.Printf("loading %v", ids)
-	ret := make([]entity.Bookmark, 0, 0)
-
-	s := make([]interface{}, len(ids))
-	for i, v := range ids {
-		s[i] = v
-	}
-
-	err := m.db.store.Find(&ret, bolthold.Where("ID").In(s...))
-	if err != nil {
-		panic(err)
-	}
-	return ret
-}
-
-func (m *BookmarkManager) Search(query string) ([]entity.Bookmark, error) {
-	rets := make([]uint64, 0, 0)
+func (m *BookmarkManager) Search(opts SearchOptions) ([]entity.Bookmark, error) {
 
+	// first get a list of all the ids that match our query
+	idsMatchingQuery := make([]uint64, 0, 0)
 	counts := make(map[uint64]uint8)
-
-	words := content.StringToSearchWords(query)
+	words := content.StringToSearchWords(opts.Query)
 
 	for _, word := range words {
 		var wi *entity.WordIndex
@@ -133,14 +122,33 @@ func (m *BookmarkManager) Search(query string) ([]entity.Bookmark, error) {
 
 	for k, v := range counts {
 		if v == uint8(len(words)) {
-			rets = append(rets, k)
-			if len(rets) > 10 {
+			idsMatchingQuery = append(idsMatchingQuery, k)
+			if len(idsMatchingQuery) > 10 {
 				break
 			}
 		}
 	}
 
-	return m.LoadBookmarksByIDs(rets), nil
+	// now we can do our search
+	bhQuery := bolthold.Query{}
+	if opts.Query != "" {
+		bhQuery = bolthold.Query(*bhQuery.And("ID").In(bolthold.Slice(idsMatchingQuery)...))
+	}
+	if opts.Tags != nil && len(opts.Tags) > 0 {
+		bhQuery = bolthold.Query(*bhQuery.And("Tags").ContainsAll(bolthold.Slice(opts.Tags)...))
+	}
+
+	out := []entity.Bookmark{}
+	err := m.db.store.ForEach(&bhQuery,
+		func(bm *entity.Bookmark) error {
+			out = append(out, *bm)
+			return nil
+		})
+	if err != nil {
+		panic(err)
+	}
+
+	return out, nil
 }
 
 func (m *BookmarkManager) ScrapeAndIndex(bm *entity.Bookmark) error {

db/bookmarks_test.go

@@ -73,7 +73,7 @@ func BenchmarkOneWordSearch(b *testing.B) {
 	bmm := NewBookmarkManager(&dbh)
 	b.ResetTimer()
 	for i := 0; i < b.N; i++ {
-		bmm.Search("hello")
+		bmm.Search(SearchOptions{Query: "hello"})
 	}
 }
 
@@ -84,7 +84,7 @@ func BenchmarkTwoWordSearch(b *testing.B) {
 	bmm := NewBookmarkManager(&dbh)
 	b.ResetTimer()
 	for i := 0; i < b.N; i++ {
-		bmm.Search("human relate")
+		bmm.Search(SearchOptions{Query: "human relate"})
 	}
 }
 
@@ -95,6 +95,6 @@ func BenchmarkThreeWordSearch(b *testing.B) {
 	bmm := NewBookmarkManager(&dbh)
 	b.ResetTimer()
 	for i := 0; i < b.N; i++ {
-		bmm.Search("human wiki editor")
+		bmm.Search(SearchOptions{Query: "human wiki editor"})
 	}
 }

db/index_test.go

@@ -47,7 +47,7 @@ func TestAddRemove(t *testing.T) {
 		t.Errorf("scrape index returned %s", err)
 	}
 
-	searchRes, err := bmm.Search("fox")
+	searchRes, err := bmm.Search(SearchOptions{Query: "fox"})
 	if err != nil {
 		t.Errorf("search returned %s", err)
 	}
@@ -62,7 +62,7 @@ func TestAddRemove(t *testing.T) {
 		t.Errorf("scrape index returned %s", err)
 	}
 
-	searchRes, err = bmm.Search("fox")
+	searchRes, err = bmm.Search(SearchOptions{Query: "fox"})
 	if err != nil {
 		t.Errorf("search returned %s", err)
 	}
@@ -70,7 +70,7 @@ func TestAddRemove(t *testing.T) {
 		t.Error("got result when should not")
 	}
 
-	searchRes, err = bmm.Search("rabbit")
+	searchRes, err = bmm.Search(SearchOptions{Query: "rabbit"})
 	if err != nil {
 		t.Errorf("search returned %s", err)
 	}
@@ -83,7 +83,7 @@ func TestAddRemove(t *testing.T) {
 		t.Errorf("got error when deleting: %s", err)
 	}
 
-	searchRes, err = bmm.Search("rabbit")
+	searchRes, err = bmm.Search(SearchOptions{Query: "rabbit"})
 	if err != nil {
 		t.Errorf("search returned %s", err)
 	}
@@ -119,7 +119,7 @@ func TestTagIndexing(t *testing.T) {
 		t.Errorf("scrape index returned %s", err)
 	}
 
-	searchRes, err := bmm.Search("fox")
+	searchRes, err := bmm.Search(SearchOptions{Query: "fox"})
 	if err != nil {
 		t.Errorf("search returned %s", err)
 	}
@@ -133,7 +133,7 @@ func TestTagIndexing(t *testing.T) {
 	if err != nil {
 		t.Errorf("scrape index returned %s", err)
 	}
-	searchRes, err = bmm.Search("sloth")
+	searchRes, err = bmm.Search(SearchOptions{Query: "sloth"})
 	if err != nil {
 		t.Errorf("search returned %s", err)
 	}

go.mod

@@ -20,7 +20,6 @@ require (
 	github.com/mattn/go-isatty v0.0.12 // indirect
 	github.com/modern-go/concurrent v0.0.0-20180228061459-e0a39a4cb421 // indirect
 	github.com/modern-go/reflect2 v0.0.0-20180701023420-4b7aa43c6742 // indirect
-	github.com/stretchr/testify v1.7.0 // indirect
 	github.com/ugorji/go/codec v1.1.7 // indirect
 	go.etcd.io/bbolt v1.3.6 // indirect
 	golang.org/x/crypto v0.0.0-20210817164053-32db794688a5 // indirect

go.sum

@@ -74,8 +74,7 @@ github.com/saintfish/chardet v0.0.0-20120816061221-3af4cd4741ca/go.mod h1:uugorj
 github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
 github.com/stretchr/testify v1.3.0/go.mod h1:M5WIy9Dh21IEIfnGCwXGc5bZfKNJtfHm1UVUgZn+9EI=
 github.com/stretchr/testify v1.4.0/go.mod h1:j7eGeouHqKxXV5pUuKE4zz7dFj8WfuZ+81PSLYec5m4=
-github.com/stretchr/testify v1.6.1 h1:hDPOHmpOpP40lSULcqw7IrRb/u7w6RpDC9399XyoNd0=
-github.com/stretchr/testify v1.6.1/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg=
+github.com/stretchr/testify v1.7.0 h1:nwc3DEeHmmLAfoZucVR881uASk0Mfjw8xYJ99tb5CcY=
 github.com/stretchr/testify v1.7.0/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg=
 github.com/temoto/robotstxt v1.1.2 h1:W2pOjSJ6SWvldyEuiFXNxz3xZ8aiWX5LbfDiOFd7Fxg=
 github.com/temoto/robotstxt v1.1.2/go.mod h1:+1AmkuG3IYkh1kv0d2qEB9Le88ehNO0zwOr3ujewlOo=

version/version.go

@@ -8,7 +8,7 @@ import (
 	"golang.org/x/mod/semver"
 )
 
-const Tag = "v0.0.19"
+const Tag = "v0.0.21"
 
 var versionInfo struct {
 	Local struct {

web/templates/_layout.html

@@ -68,10 +68,9 @@
       {{/* template "foundation_sample.html" . */}}
     </div>
 
-
-    <!-- <script src="/assets/js/vendor/jquery.js"></script>
     <script src="/assets/js/vendor/what-input.js"></script>
+    <script src="/assets/js/vendor/jquery.js"></script>
     <script src="/assets/js/vendor/foundation.js"></script>
-    <script src="/assets/js/app.js"></script> -->
+    <script src="/assets/js/app.js"></script>
   </body>
 </html>

web/templates/manage.html

@@ -1,38 +1,20 @@
-<div class="grid-x grid-padding-x">
+<div class="grid-x grid-padding-x" id="manage">
     <div class="large-12 cell">
 
         <h5>Manage links</h5>
 
-        <table>
-            <tr>
-                <th>&nbsp;</th>
-                <th>title/url</th>
-                <th>tags</th>
-                <th class="show-for-large">created</th>
-                <th class="show-for-large">scraped</th>
-            </tr>
-            {{ range .bookmarks }}
-            <tr>
-                <th><a class="button" href="/edit/{{ .ID }}">edit</a></th>
-                <td>
-                    <a href="{{ .URL }}">{{ .Info.Title }}</a>
-                    <br>
-                    <a href="{{ .URL }}">{{ niceURL .URL }}</a>
-                </td>
-                <td>
-                    {{ range .Tags }}
-                    <span class="label primary">{{ . }}</span>
-                    {{ end }}
-                </td>
-                <td class="show-for-large">{{ (nicetime .TimestampCreated).HumanDuration }} ago</td>
-                <td class="show-for-large">{{ (nicetime .TimestampLastScraped).HumanDuration }} ago</td>
-
-                <td>
-                    <a class="button" hx-swap="outerHTML" hx-post="/scrape/{{ .ID }}">scrape</button>
-                </td>
-            </tr>
-            {{ end }}
-        </table>
+        <form onsubmit="return false"> 
+            <div class="grid-x grid-padding-x">
+                <div class="large-12 cell">
+                    <label>Filter</label>
+                    <input type="text" name="query" placeholder="" hx-post="/manage/results" hx-swap="outerHTML"
+                        hx-trigger="keyup changed delay:500ms, tag_update" hx-target="#manage-results"
+                        hx-indicator="#htmx-indicator-search" id="manage-search" />
+                </div>
+            </div>
+            {{ template "tags_widget.html" . }}
+        </form>
+        {{ template "manage_results.html" . }}
      
     </div>
 </div>

web/templates/manage_results.html

@@ -0,0 +1,31 @@
+
+        <table id="manage-results">
+            <tr>
+                <th>&nbsp;</th>
+                <th>title/url</th>
+                <th>tags</th>
+                <th class="show-for-large">created</th>
+                <th class="show-for-large">scraped</th>
+            </tr>
+            {{ range .bookmarks }}
+            <tr>
+                <th><a class="button" href="/edit/{{ .ID }}">edit</a></th>
+                <td>
+                    <a href="{{ .URL }}">{{ .Info.Title }}</a>
+                    <br>
+                    <a href="{{ .URL }}">{{ niceURL .URL }}</a>
+                </td>
+                <td>
+                    {{ range .Tags }}
+                    <span class="label primary">{{ . }}</span>
+                    {{ end }}
+                </td>
+                <td class="show-for-large">{{ (nicetime .TimestampCreated).HumanDuration }} ago</td>
+                <td class="show-for-large">{{ (nicetime .TimestampLastScraped).HumanDuration }} ago</td>
+
+                <td>
+                    <a class="button" hx-swap="outerHTML" hx-post="/scrape/{{ .ID }}">scrape</button>
+                </td>
+            </tr>
+            {{ end }}
+        </table>

web/templates/tags_widget.html

@@ -1,4 +1,4 @@
-<div id="label-widget">
+<div id="label-widget" >
     <div class="grid-x grid-padding-x">
         <div class="small-9 medium-10 large-5 cell" 
             hx-post="/tags"
@@ -9,7 +9,7 @@
 
             <input id="tag-entry" type="text" name="tag" placeholder="enter tags" />
         </div>
-        <div class="small-12 large-6 cell">
+        <div class="small-12 large-6 cell" id="tags-list">
             {{ range .tags }}
             <a href="#"
                class=""
@@ -20,7 +20,7 @@
                <span class="label primary">{{ . }}</span> 
             
             {{ end }}
-            <input type="hidden" name="tags_hidden" value="{{ .tags_hidden }}">
+            <input _="on load send tag_update to #manage-search" type="hidden" id="tags-hidden" name="tags_hidden" value="{{ .tags_hidden }}">
         </div>    
     </div>
 </div>

web/web.go

@@ -81,6 +81,7 @@ func Create(bmm *db.BookmarkManager, cmm *db.ConfigManager) *Server {
 	})
 
 	r.GET("/manage", func(c *gin.Context) {
+
 		allBookmarks, _ := bmm.ListBookmarks()
 		meta := gin.H{"page": "manage", "config": config, "bookmarks": allBookmarks}
 		c.HTML(http.StatusOK,
@@ -88,6 +89,23 @@ func Create(bmm *db.BookmarkManager, cmm *db.ConfigManager) *Server {
 		)
 	})
 
+	r.POST("/manage/results", func(c *gin.Context) {
+		query := c.PostForm("query")
+		tags := []string{}
+		if c.PostForm("tags_hidden") != "" {
+			tags = strings.Split(c.PostForm("tags_hidden"), "|")
+		}
+		allBookmarks, _ := bmm.Search(db.SearchOptions{Query: query, Tags: tags})
+		meta := gin.H{"config": config, "bookmarks": allBookmarks}
+
+		log.Printf("query is %s, tags %v", query, tags)
+
+		c.HTML(http.StatusOK,
+			"manage_results.html", meta,
+		)
+
+	})
+
 	r.GET("/config", func(c *gin.Context) {
 		meta := gin.H{"page": "config", "config": config}
 		c.HTML(http.StatusOK,
@@ -107,7 +125,7 @@ func Create(bmm *db.BookmarkManager, cmm *db.ConfigManager) *Server {
 	r.POST("/search", func(c *gin.Context) {
 		query := c.PostForm("query")
 
-		sr, err := bmm.Search(query)
+		sr, err := bmm.Search(db.SearchOptions{Query: query})
 		data := gin.H{
 			"results": sr,
 			"error":   err,